Define maximum yenc part size as constant

sabnzbd · Apr 17, 2023 · ee3388f · ee3388f
1 parent c96089c
commit ee3388f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/sabctools.h b/src/sabctools.h
@@ -22,6 +22,6 @@
 #include <string.h>
 
 /* Version information */
-#define SABCTOOLS_VERSION "7.0.0"
+#define SABCTOOLS_VERSION "7.0.1"
 
 PyMODINIT_FUNC PyInit_sabctools(void);
diff --git a/src/yenc.cc b/src/yenc.cc
@@ -148,7 +148,7 @@ PyObject* yenc_decode(PyObject* self, PyObject* Py_bytesarray_obj) {
 
         // Get the size and sanity check the values
         part_size = part_end - part_begin + 1;
-        if(part_end > part_begin && part_size > 0 && part_size <= 10*1024*1024) {
+        if(part_end > part_begin && part_size > 0 && part_size <= YENC_MAX_PART_SIZE) {
             part_begin = part_begin - 1;
         } else {
             part_size = part_end = part_begin = 0;

diff --git a/src/yenc.h b/src/yenc.h
@@ -32,9 +32,12 @@
 #define YENC_CR          0x0d
 #define YENC_LF          0x0a
 
-/* The =yend line cannot be crazy long*/
+/* The =yend line cannot be crazy long */
 #define YENC_MAX_TAIL_BYTES 256
 
+/* Prevent strange yEnc sizes */
+#define YENC_MAX_PART_SIZE 10*1024*1024
+
 /* Functions */
 PyObject* yenc_decode(PyObject *, PyObject*);
 PyObject* yenc_encode(PyObject *, PyObject*);