New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Front end engineering for searchable NZB queue! #77
Conversation
Nice work! I have the matching Python code ready. When updating the "Search" box, the actual content of the queue only changes at the next refresh. In History, the Purge command also uses the current "Search" field. I see you duplicated the $.plush.RefreshQueue() code in Plush.js. |
BTW: I have pushed the Python code, so it should be easier for you to test. |
No problem, this and the Queue Purge param are both now complete in 6749202.
Thanks! It's working great. Excited to have this! |
Good job, works as intended. |
sure. do you want me to also rebase both dbe5700 and 6749202 into one commit? |
Please do, nice to have it in one change-set. |
Matches UI + behavior of history search (search updates on Enter press and Queue Purge respects current queue search value)
OK, 200c3d8 is now one clean commit, and I rebased to develop! |
Plush: front-end engineering for searchable NZB queue.
Thank you for a very useful contribution. |
Introduction of searchbox (merge request #77) messed up checkboxes, due to a debug version of $.plush.RefreshQueue() overriding the normal version.
OK, I implemented the front-end UI changes to make the queue searchable! 馃攳 Search box adjusts as the window resizes and matches the history search UI.
@shypike, you'll need to tweak
_api_queue
to accept a search string filter聽param like_api_history
, but i'm hoping that's easy for you now that the UI work's done (easy for me).Changes tested in Chrome, Firefox, and Safari. Please LMK if there's an official SABnzbd browser suite that changes get tested against.