Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front end engineering for searchable NZB queue! #77

Merged
merged 1 commit into from Feb 11, 2013
Merged

Front end engineering for searchable NZB queue! #77

merged 1 commit into from Feb 11, 2013

Conversation

jm3
Copy link
Contributor

@jm3 jm3 commented Feb 8, 2013

I've been trying to add a search box to the queue in Plush,
like the History has. I haven't succeeded...

OK, I implemented the front-end UI changes to make the queue searchable! 馃攳 Search box adjusts as the window resizes and matches the history search UI.

@shypike, you'll need to tweak _api_queue to accept a search string filter聽param like _api_history, but i'm hoping that's easy for you now that the UI work's done (easy for me).

Changes tested in Chrome, Firefox, and Safari. Please LMK if there's an official SABnzbd browser suite that changes get tested against.

searchable-queue-UI

@shypike
Copy link
Member

shypike commented Feb 10, 2013

Nice work! I have the matching Python code ready.
Just a few more requests/remarks.

When updating the "Search" box, the actual content of the queue only changes at the next refresh.
For people who use a slow refresh rate, this looks very confusing.
Is it possible to force a refresh of the queue when the return key is hit?
(This already works so for History Search.)

In History, the Purge command also uses the current "Search" field.
Can you pass the current queue "search" value as a parameter to the Queue Purge command as well?
(Queue Purge is the pull down menu at the right top side of the queue.)

I see you duplicated the $.plush.RefreshQueue() code in Plush.js.
That looks a bit awkward in the diffs. Can you remove the original procedure?

@shypike
Copy link
Member

shypike commented Feb 10, 2013

BTW: I have pushed the Python code, so it should be easier for you to test.

@jm3
Copy link
Contributor Author

jm3 commented Feb 11, 2013

Is it possible to force a refresh of the queue when the return key is hit?

No problem, this and the Queue Purge param are both now complete in 6749202.
Also removed the duplicated RefreshQueue() stuff; still learning the codebase... 馃悾

BTW: I have pushed the Python code, so it should be easier for you to test.

Thanks! It's working great. Excited to have this!

@shypike
Copy link
Member

shypike commented Feb 11, 2013

Good job, works as intended.
One final question. Can you rebase your branch to "develop"?
That way the git log looks cleaner.
I can use a patch of course, but I want to preserve your name in the log.

@jm3
Copy link
Contributor Author

jm3 commented Feb 11, 2013

sure. do you want me to also rebase both dbe5700 and 6749202 into one commit?

@shypike
Copy link
Member

shypike commented Feb 11, 2013

Please do, nice to have it in one change-set.

Matches UI + behavior of history search (search updates on Enter press
and Queue Purge respects current queue search value)
@jm3
Copy link
Contributor Author

jm3 commented Feb 11, 2013

OK, 200c3d8 is now one clean commit, and I rebased to develop!

shypike added a commit that referenced this pull request Feb 11, 2013
Plush: front-end engineering for searchable NZB queue.
@shypike shypike merged commit 4989e8c into sabnzbd:develop Feb 11, 2013
@shypike
Copy link
Member

shypike commented Feb 11, 2013

Thank you for a very useful contribution.

shypike added a commit that referenced this pull request Mar 9, 2013
Introduction of searchbox (merge request #77) messed up checkboxes,
due to a debug version of $.plush.RefreshQueue() overriding the normal version.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants