Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix abstract superclasses not being represented in the copy constructor #86

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

gitterrost4
Copy link

@gitterrost4 gitterrost4 commented Jan 11, 2023

This commit removes the check for a superclass field being a DefinedClass. This check would prevent primitive (or other) types of superclass-fields to be added to the copy constructor.

I also added a test case for this.

This fixes #85 .

@sabomichal sabomichal merged commit e359ba0 into sabomichal:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Builder constructor with other object does not set fields from the base class
2 participants