PHP 8.2 dynamic properties deprecation warnings #1154

AaronVanGeffen · 2023-01-27T19:35:37Z

Baikal version: 0.9.3

In PHP 8.2, dynamic class properties have been deprecated. Apparently, Sabre\DAV still uses some in at least two locations, leading to errors below.

Baikal is working again after quickly patching the two classes. I do not currently have time to upstream my changes, but I thought I'd report these findings either way, in case others run into similar issues. I have also filed an issue upstream: sabre-io/dav#1445

PHP message: ErrorException: Creation of dynamic property Sabre\DAV\Xml\Property\Href::$autoPrefix is deprecated in /usr/share/webapps/baikal/vendor/sabre/dav/lib/DAV/PropertyStorage/Backend/PDO.php:100
Stack trace:
#0 [internal function]: Baikal\Framework::exception_error_handler()
#1 /usr/share/webapps/baikal/vendor/sabre/dav/lib/DAV/PropertyStorage/Backend/PDO.php(100): unserialize()
#2 /usr/share/webapps/baikal/vendor/sabre/dav/lib/DAV/PropertyStorage/Plugin.php(84): Sabre\DAV\PropertyStorage\Backend\PDO->propFind()
#3 /usr/share/webapps/baikal/vendor/sabre/event/lib/WildcardEmitterTrait.php(89): Sabre\DAV\PropertyStorage\Plugin->propFind()
#4 /usr/share/webapps/baikal/vendor/sabre/dav/lib/DAV/Server.php(1052): Sabre\DAV\Server->emit()
#5 /usr/share/webapps/baikal/vendor/sabre/dav/lib/DAV/Server.php(984): Sabre\DAV\Server->getPropertiesByNode()
#6 /usr/share/webapps/baikal/vendor/sabre/dav/lib/DAV/Server.php(1662): Sabre\DAV\Server->getPropertiesIteratorForPath()
#7 /usr/share/webapps/baikal/v

PHP message: ErrorException: Creation of dynamic property Sabre\CardDAV\Xml\Request\AddressBookMultiGetReport::$addressDataProperties is deprecated in /usr/share/webapps/baikal/vendor/sabre/dav/lib/CardDAV/Xml/Request/AddressBookMultiGetReport.php:104
Stack trace:
#0 /usr/share/webapps/baikal/vendor/sabre/dav/lib/CardDAV/Xml/Request/AddressBookMultiGetReport.php(104): Baikal\Framework::exception_error_handler()
#1 [internal function]: Sabre\CardDAV\Xml\Request\AddressBookMultiGetReport::xmlDeserialize()
#2 /usr/share/webapps/baikal/vendor/sabre/xml/lib/Reader.php(234): call_user_func()
#3 /usr/share/webapps/baikal/vendor/sabre/xml/lib/Reader.php(75): Sabre\Xml\Reader->parseCurrentElement()
#4 /usr/share/webapps/baikal/vendor/sabre/xml/lib/Service.php(129): Sabre\Xml\Reader->parse()
#5 /usr/share/webapps/baikal/vendor/sabre/dav/lib/DAV/CorePlugin.php(679): Sabre\Xml\Service->parse()
#6 /usr/share/webapps/baikal/vendor/sabre/event/lib/WildcardEmitterTrait.php(89): Sabre\DAV\CorePlugin->httpReport()

The text was updated successfully, but these errors were encountered:

AllesMeins · 2023-02-12T12:44:23Z

I've the same problem - could you tell me what exactly you did to fix it?

AaronVanGeffen · 2023-02-12T13:05:58Z

Per the error messages, I added two properties:

protected $autoPrefix; to the Href class (baikal/vendor/sabre/dav/lib/DAV/Xml/Property/Href.php)
public $addressDataProperties; to the AddressBookMultiGetReport class (baikal/vendor/sabre/dav/lib/CardDAV/Xml/Request/AddressBookMultiGetReport.php)

AllesMeins · 2023-02-12T13:53:42Z

Ah, perfect - thank you!

N0ury · 2023-02-12T19:19:42Z

same problem for me.
@AaronVanGeffen fix worked for me too.

rodin-ia · 2023-02-17T07:04:39Z

Tnks! It also solved the problem with the display of contacts in InfCLoud.

codeandfix · 2023-04-08T10:18:40Z

Creation of dynamic property Sabre\CardDAV\Xml\Request\AddressBookMultiGetReport::$addressDataProperties is deprecated
also malfunct

jwohlfeil · 2023-04-21T14:58:31Z

Works for me, too. I'm using PHP 8.2.

TCB13 · 2023-05-08T15:45:40Z

Also works for me in PHP 8.2. thanks!

gizmo15 · 2023-06-09T08:29:18Z

Works for me too with PHP 8.2.5, thanks!

cscholz · 2023-06-09T21:49:27Z

@AaronVanGeffen: Will there be a new Baikal Dav Version containing the fix or is an manuel modification required?

AaronVanGeffen · 2023-06-09T21:52:12Z

@AaronVanGeffen: Will there be a new Baikal Dav Version containing the fix or is an manuel modification required?

I don't maintain Baikal; I just filed the bug report.

antiftw · 2023-06-11T17:45:02Z

Hi,

I arrived here because of problems syncing my contacts from a personal Baikal server with DavX5 which suddenly stopped working after a server reinstall which entailed a PHP upgrade from 8.1 to 8.2

@cscholz as you can see here sabre-io/dav#1446 there is an open pullrequest that needs to be merged. I also wrote a comment there asking if this might be done in the near future. Until then you can just modify the file manually, as can be seen here:

sabre-io/dav@906bbb8

anekinloewe · 2023-07-19T15:22:22Z

Works fine for me on debian 12.

PatrickJMaloney · 2023-08-09T05:09:44Z

@AaronVanGeffen Thanks for the fix. Using PHP 8.2.8.

gour · 2023-09-27T16:47:10Z

Thanks a lot! It helps to me as well on the server running Debian & PHP-8.2.10. 😄

cl0rm · 2023-10-03T18:08:38Z

Thanks. Updated from Debian 11 to 12, this is needed for the adress book to work correctly

Fijxu · 2023-10-23T16:51:32Z

I wasn't able to see what contacts I had in my Address Book using Thunderbird 115 but adding those 2 lines fixed the problem.

Previously it was returning error 500 when the REPORT request was made. I hope this gets fixed so people don't need to change the files manually.

AaronVanGeffen · 2023-11-17T10:48:29Z

Looks like this is all fixed in the latest release. Thanks!

AaronVanGeffen · 2023-11-21T18:10:43Z

It seems I spoke too soon. Calendar syncing works without issue, but the issue with address books still remains:

2023/11/21 19:05:43 [error] 566#566: *20360 FastCGI sent in stderr:
"PHP message: ErrorException: Creation of dynamic property Sabre\DAV\Xml\Property\Href::$autoPrefix is deprecated in /usr/share/webapps/baikal/vendor/sabre/dav/lib/DAV/PropertyStorage/Backend/PDO.php:100
Stack trace:
#0 [internal function]: Baikal\Framework::exception_error_handler()
#1 /usr/share/webapps/baikal/vendor/sabre/dav/lib/DAV/PropertyStorage/Backend/PDO.php(100): unserialize()
#2 /usr/share/webapps/baikal/vendor/sabre/dav/lib/DAV/PropertyStorage/Plugin.php(84): Sabre\DAV\PropertyStorage\Backend\PDO->propFind()
#3 /usr/share/webapps/baikal/vendor/sabre/event/lib/WildcardEmitterTrait.php(89): Sabre\DAV\PropertyStorage\Plugin->propFind()
#4 /usr/share/webapps/baikal/vendor/sabre/dav/lib/DAV/Server.php(1052): Sabre\DAV\Server->emit()
#5 /usr/share/webapps/baikal/vendor/sabre/dav/lib/DAV/Server.php(984): Sabre\DAV\Server->getPropertiesByNode()
#6 /usr/share/webapps/baikal/vendor/sabre/dav/lib/DAV/Server.php(1662): Sabre\DAV\Server->getPropertiesIteratorForPath()
#7 /usr/share/webapps/baikal/v" while reading response header from upstream

The fix for this is still what I reported back in February: #1154 (comment)

Add protected $autoPrefix; to the Href class (baikal/vendor/sabre/dav/lib/DAV/Xml/Property/Href.php)

DeepDiver1975 · 2023-11-21T18:59:12Z

I guess Baikal needs to update deps....

phil-davis · 2023-11-22T05:57:04Z

I guess Baikal needs to update deps....

That should have happened in https://github.com/sabre-io/Baikal/releases/tag/0.9.4

But I don't understand the $autoPrefix thing. I can't find $autoPrefix anywhere in the current sabre/dav code or its dependencies. Can someone give me a hint about what sabre/dav code touches $autoPrefix ?

DeepDiver1975 · 2023-11-22T09:14:29Z

@AaronVanGeffen how did you install/upgrade your bailkal installation? Maybe we get some hints from this ...

DeepDiver1975 · 2023-11-22T09:22:17Z

#1 /usr/share/webapps/baikal/vendor/sabre/dav/lib/DAV/PropertyStorage/Backend/PDO.php(100): unserialize()

Ah - that's it I guess .... the serialized vobject here holds a reference to autoPrefix which does not exist.

The only option I see is to add this property back in Href ....

phil-davis · 2023-11-22T10:37:52Z

autoPrefix stuff was removed in PR sabre-io/dav#801

I will have a look and see what bits should be put back to keep backward-compatibility of some sort. I suppose that this is only noticed when there are (quite) old VOJBECTs in the database that have/generate calendar dates that still happen in "real life" at run-time for people.

use of this property in code was removed in PR sabre-io#801 But the property is left here because old data may still exist that has this property saved. See discussion in sabre-io/Baikal#1154

use of this property in code was removed in PR #801 But the property is left here because old data may still exist that has this property saved. See discussion in sabre-io/Baikal#1154

use of this property in code was removed in PR sabre-io#801 But the property is left here because old data may still exist that has this property saved. See discussion in sabre-io/Baikal#1154

phil-davis · 2023-11-23T04:47:15Z

Release https://github.com/sabre-io/dav/releases/tag/4.5.1 should have fixed the HRef autoPrefix problem.

Baikal composer.json has:

"sabre/dav"     : "~4.5.0",

and no composer.lock

So sabre/dav 4.5.1 should be picked up automagicall without any code change here.

But I see that the release 0.9.4 comes with a zip file that has the vendor dependenices pre-packages:
https://github.com/sabre-io/Baikal/releases/download/0.9.4/baikal-0.9.4.zip

So I suppose that 0.9.5 has to be released to provide updated "bundled" sabre/dav 4.5.1

mxmehl · 2024-01-02T07:42:34Z

Upgrading to Baikal 0.9.4 solved this issue with PHP 8.2 for me.

It was basically a matter of cp -R baikal-0.9.4/* baikal/ (where baikal/ is the path of my existing installation)

AaronVanGeffen mentioned this issue Jan 27, 2023

PHP 8.2 dynamic properties deprecation warnings sabre-io/dav#1445

Closed

This was referenced Aug 18, 2023

HTTP 500 from Evolution & DAVx5 #1197

Closed

After Login and update to Debian Bookworm users cannot login any more #1169

Closed

arminwedler mentioned this issue Oct 5, 2023

401 errors #1204

Open

opa-rudi mentioned this issue Oct 11, 2023

ErrorException: Creation of dynamic property #1205

Closed

thelittleblackbird mentioned this issue Oct 19, 2023

sabre framework response with error 500 with PHP 8.2 tchapi/davis#115

Closed

arminwedler mentioned this issue Nov 4, 2023

New release 4.5.0 sabre-io/dav#1493

Closed

AaronVanGeffen closed this as completed Nov 17, 2023

AaronVanGeffen reopened this Nov 21, 2023

phil-davis mentioned this issue Nov 22, 2023

fix: restore autoPrefix property of Href sabre-io/dav#1514

Merged

DeepDiver1975 closed this as completed in sabre-io/dav#1514 Nov 22, 2023

phil-davis mentioned this issue Nov 23, 2023

[4.5] fix: restore autoPrefix property of Href sabre-io/dav#1515

Merged

ByteHamster reopened this Nov 23, 2023

phil-davis mentioned this issue Mar 17, 2024

Address book not showing up in DAVx5 #1234

Closed

ByteHamster closed this as completed Mar 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PHP 8.2 dynamic properties deprecation warnings #1154

PHP 8.2 dynamic properties deprecation warnings #1154

AaronVanGeffen commented Jan 27, 2023

AllesMeins commented Feb 12, 2023

AaronVanGeffen commented Feb 12, 2023

AllesMeins commented Feb 12, 2023

N0ury commented Feb 12, 2023

rodin-ia commented Feb 17, 2023

codeandfix commented Apr 8, 2023

jwohlfeil commented Apr 21, 2023

TCB13 commented May 8, 2023

gizmo15 commented Jun 9, 2023

cscholz commented Jun 9, 2023

AaronVanGeffen commented Jun 9, 2023

antiftw commented Jun 11, 2023

anekinloewe commented Jul 19, 2023

PatrickJMaloney commented Aug 9, 2023

gour commented Sep 27, 2023

cl0rm commented Oct 3, 2023

Fijxu commented Oct 23, 2023

AaronVanGeffen commented Nov 17, 2023

AaronVanGeffen commented Nov 21, 2023

DeepDiver1975 commented Nov 21, 2023

phil-davis commented Nov 22, 2023

DeepDiver1975 commented Nov 22, 2023

DeepDiver1975 commented Nov 22, 2023

phil-davis commented Nov 22, 2023

phil-davis commented Nov 23, 2023 •

edited

Loading

mxmehl commented Jan 2, 2024

PHP 8.2 dynamic properties deprecation warnings #1154

PHP 8.2 dynamic properties deprecation warnings #1154

Comments

AaronVanGeffen commented Jan 27, 2023

AllesMeins commented Feb 12, 2023

AaronVanGeffen commented Feb 12, 2023

AllesMeins commented Feb 12, 2023

N0ury commented Feb 12, 2023

rodin-ia commented Feb 17, 2023

codeandfix commented Apr 8, 2023

jwohlfeil commented Apr 21, 2023

TCB13 commented May 8, 2023

gizmo15 commented Jun 9, 2023

cscholz commented Jun 9, 2023

AaronVanGeffen commented Jun 9, 2023

antiftw commented Jun 11, 2023

anekinloewe commented Jul 19, 2023

PatrickJMaloney commented Aug 9, 2023

gour commented Sep 27, 2023

cl0rm commented Oct 3, 2023

Fijxu commented Oct 23, 2023

AaronVanGeffen commented Nov 17, 2023

AaronVanGeffen commented Nov 21, 2023

DeepDiver1975 commented Nov 21, 2023

phil-davis commented Nov 22, 2023

DeepDiver1975 commented Nov 22, 2023

DeepDiver1975 commented Nov 22, 2023

phil-davis commented Nov 22, 2023

phil-davis commented Nov 23, 2023 • edited Loading

mxmehl commented Jan 2, 2024

phil-davis commented Nov 23, 2023 •

edited

Loading