Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump php-cs-fixer to 3.54.0 #1257

Closed
wants to merge 1 commit into from

Conversation

phil-davis
Copy link
Contributor

Note php-cs-fixer now complains about 'binary_operator_spaces' being set to an empty array.
It wants the default setting to be explicitly mentioned.

$ composer cs-fixer
> php-cs-fixer fix
PHP CS Fixer 3.54.0 15 Keys Accelerate by Fabien Potencier, Dariusz Ruminski and contributors.
PHP runtime: 7.4.3-4ubuntu2.20
Loaded config default from "/home/phil/git/sabre-io/Baikal/.php-cs-fixer.dist.php".
Using cache file ".php-cs-fixer.cache".
   0/117 [░░░░░░░░░░░░░░░░░░░░░░░░░░░░]   0%
In FixerFactory.php line 164:
                                                                                 
  [binary_operator_spaces] Configuration must be an array and may not be empty.  
                                                                                 

fix [--path-mode PATH-MODE] [--allow-risky ALLOW-RISKY] [--config CONFIG] [--dry-run] [--rules RULES] [--using-cache USING-CACHE] [--cache-file CACHE-FILE] [--diff] [--format FORMAT] [--stop-on-violation] [--show-progress SHOW-PROGRESS] [--] [<path>...]

Script php-cs-fixer fix handling the cs-fixer event returned with error code 32

So I have chosen 'at_least_single_space' - that allows existing to pass cs-fixer.

The various settings options are mentioned here:
https://cs.symfony.com/doc/rules/operator/binary_operator_spaces.html

@phil-davis
Copy link
Contributor Author

See dependabot PR #1262

@phil-davis phil-davis closed this May 1, 2024
@phil-davis phil-davis deleted the bump-cs-fixer-3.54.0 branch May 1, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant