Add phpstan to travis #1091
Add phpstan to travis #1091
Conversation
DeepDiver1975
force-pushed
the
feature/add-phpstan
branch
5 times, most recently
from
5759083
to
4c94f06
Compare
Codecov Report
@@ Coverage Diff @@
## master #1091 +/- ##
============================================
- Coverage 97.21% 97.19% -0.02%
+ Complexity 2871 2865 -6
============================================
Files 174 174
Lines 8067 8057 -10
============================================
- Hits 7842 7831 -11
- Misses 225 226 +1
Continue to review full report at Codecov.
|
| @@ -3,6 +3,7 @@ | |||
| namespace Sabre\CalDAV; | |||
|
|
|||
| use DateTimeZone; | |||
| use Sabre\CalDAV\Xml\Request\CalendarMultiGetReport; | |||
There was a problem hiding this comment.
It is used in PHPDoc as type annotation
| @@ -136,8 +136,7 @@ function propFindEarly(DAV\PropFind $propFind, DAV\INode $node) { | |||
| } | |||
|
|
|||
| return new Xml\Property\Invite( | |||
| $node->getInvites(), | |||
| $ownerInfo | |||
| $node->getInvites() | |||
There was a problem hiding this comment.
When ownerInfo really is not required here, we should also delete some of the logic above this line
There was a problem hiding this comment.
Invite:__construct only take one arg .... I will review the code once more .... THX for the pointer
phpstan.neon
Outdated
| bootstrap: %currentWorkingDirectory%/vendor/autoload.php | ||
|
|
||
| excludes_analyse: | ||
| - %currentWorkingDirectory%/lib/DAV/Auth/Backend/IMAP.php |
There was a problem hiding this comment.
Will add comment - because the imap module is only a suggested dependency .... need to have a second look ...
DeepDiver1975
force-pushed
the
feature/add-phpstan
branch
from
4c94f06
to
6cb7a65
Compare
| @@ -69,7 +69,7 @@ static function xmlDeserialize(Reader $reader) { | |||
| * {DAV:}property elements. | |||
| * | |||
| * @param array $elems | |||
| * @return void | |||
| * @return array | |||
There was a problem hiding this comment.
the returned array could also hold an array of strings itself .... just given by the code logic
DeepDiver1975
force-pushed
the
feature/add-phpstan
branch
3 times, most recently
from
16f6c8c
to
b80b543
Compare
|
@staabm final review please - all should be sorted out now. THX |
| @@ -46,6 +46,7 @@ class SchedulingObject extends \Sabre\CalDAV\CalendarObject implements IScheduli | |||
| * @param array $objectData | |||
| */ | |||
| function __construct(Backend\SchedulingSupport $caldavBackend, array $objectData) { | |||
| parent::__construct($caldavBackend, [], $objectData); | |||
|
|
|||
| $this->caldavBackend = $caldavBackend; | |||
There was a problem hiding this comment.
Is this assignment redundant with the parent impl?
There was a problem hiding this comment.
yes - I need to have a closer look. The PHPDoc type annotation is different.
DeepDiver1975
force-pushed
the
feature/add-phpstan
branch
from
b80b543
to
c6128dd
Compare
|
@staabm ready for some final review? THX |
|
Hmm seems build is failling |
DeepDiver1975
force-pushed
the
feature/add-phpstan
branch
from
c6128dd
to
bdbb2a6
Compare
|
@staabm fixed now |
|
Cool thx |
No description provided.