Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use php-cs-fixer 3.51 #234

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Conversation

phil-davis
Copy link
Contributor

php-cs-fixer 3.49 (or some recent minor release) wants to use the ? (nullable) syntax on optional parameters.
That syntax has been supported for quite a while since PHP https://www.php.net/manual/en/migration71.new-features.php

In the cases here, as well as the default value of the parameter being null, the ? explicitly allows the caller to pass the value null if they want.

This seems reasonable, I don't see how it can break any existing usage.

@phil-davis phil-davis self-assigned this Feb 11, 2024
@phil-davis
Copy link
Contributor Author

Similar to sabre-io/xml#271

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.17%. Comparing base (710f154) to head (d2581c7).
Report is 2 commits behind head on master.

❗ Current head d2581c7 differs from pull request most recent head ccbfb1a. Consider uploading reports for the commit ccbfb1a to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #234      +/-   ##
============================================
- Coverage     94.21%   94.17%   -0.05%     
  Complexity      261      261              
============================================
  Files            15       15              
  Lines           882      875       -7     
============================================
- Hits            831      824       -7     
  Misses           51       51              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phil-davis
Copy link
Contributor Author

Has a minor complaint about project code coverage - strange report, the codecov/patch reports 100% of diff hit.

@phil-davis phil-davis changed the title chore: use php-cs-fixer 3.49 chore: use php-cs-fixer 3.51 Mar 4, 2024
@phil-davis phil-davis merged commit 7aef10a into sabre-io:master Mar 4, 2024
5 checks passed
@phil-davis phil-davis deleted the cs-fixer-3.49 branch March 4, 2024 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant