Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump phpstan to 0.12 #46

Merged
merged 2 commits into from
Jan 26, 2020
Merged

Bump phpstan to 0.12 #46

merged 2 commits into from
Jan 26, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jan 25, 2020

and enhance some PHPdoc to keep phpstan happy.

phpstan was fussing about:

 ------ ----------------------------------------------------------------------- 
  Line   functions.php                                                          
 ------ ----------------------------------------------------------------------- 
  192    Function Sabre\Uri\parse() return type has no value type specified in  
         iterable type array.                                                   
         馃挕 Consider adding something like array<Foo> to the                     
         PHPDoc.                                                                
         You can turn off this check by setting                                 
         checkMissingIterableValueType: false in your                           
         /home/travis/build/sabre-io/uri/phpstan.neon.                          

  232    Function Sabre\Uri\build() has parameter $parts with no value type     
         specified in iterable type array.                                      
         m馃挕 Consider adding something like array<Foo> to the                     
         PHPDoc.                                                                
         You can turn off this check by setting                                 
         checkMissingIterableValueType: false in your                           
         /home/travis/build/sabre-io/uri/phpstan.neon.                          

  288    Function Sabre\Uri\split() return type has no value type specified in  
         iterable type array.                                                   

         馃挕 Consider adding something like array<Foo> to the                     
         PHPDoc.                                                                
         You can turn off this check by setting                                 
         checkMissingIterableValueType: false in your                           
         /home/travis/build/sabre-io/uri/phpstan.neon.                          

  314    Function Sabre\Uri\_parse_fallback() return type has no value type     

         specified in iterable type array.                                      
         馃挕 Consider adding something like array<Foo> to the                     
         PHPDoc.                                                                
         You can turn off this check by setting                                 
         checkMissingIterableValueType: false in your                           
         /home/travis/build/sabre-io/uri/phpstan.neon.                          
 ------ ----------------------------------------------------------------------- 
                                                                              
 [ERROR] Found 4 errors                                                         

@phil-davis phil-davis self-assigned this Jan 25, 2020
@phil-davis phil-davis marked this pull request as ready for review January 25, 2020 16:13
@phil-davis phil-davis merged commit 7bc19fe into sabre-io:master Jan 26, 2020
@phil-davis phil-davis deleted the bump-php-stan branch January 26, 2020 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants