Fixed phpstan level 1 errors #487
Conversation
Codecov Report
@@ Coverage Diff @@
## master #487 +/- ##
=========================================
Coverage 98.68% 98.69%
Complexity 1757 1757
=========================================
Files 66 66
Lines 4271 4279 +8
=========================================
+ Hits 4215 4223 +8
Misses 56 56 Continue to review full report at Codecov.
|
| @@ -608,6 +614,7 @@ protected function nextYearly() | |||
| // If we got a byDay or getMonthDay filter, we must first expand | |||
| // further. | |||
| if ($this->byDay || $this->byMonthDay) { | |||
| $occurrence = -1; | |||
There was a problem hiding this comment.
$occurrence may not be defined by the time it is used on line 654.
|
May I ask why this is yet to be merged? As far as I know, all requested changes have been done. |
|
Please give us a few more days for final reviews. Thx for working on it. @DeepDiver1975 any feedback left? |
|
@DeepDiver1975 this has been rebased just now on top of current master. |
|
@staabm merge, or wait for @DeepDiver1975 to review again? |
|
Feel free to merge |
|
@JeroenVanOort thanks! |
This fixes all phpstan level 1 errors and enables checking for them in CI. I'm working on a PR to also fix level 2 errors.