Rullzer prevent inf loop #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepDiver1975
force-pushed
the
rullzer-prevent_inf_loop
branch
2 times, most recently
from
10a081f
to
f652b5d
Compare
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
DeepDiver1975
force-pushed
the
rullzer-prevent_inf_loop
branch
from
f652b5d
to
771f945
Compare
|
Did you check the test will fail without the patch? |
staabm
approved these changes
Sep 25, 2018
|
Thanks for taking over @DeepDiver1975 |
|
This unit test is not hitting the code in question - I need to have a second look .... |
DeepDiver1975
commented
Sep 26, 2018
| @@ -155,6 +155,25 @@ function testExpectStream() { | |||
| ); | |||
| } | |||
|
|
|||
| function testEmptyProps() { | |||
There was a problem hiding this comment.
@rullzer this test should now reflect your description. But this does not trigger the infinite loop. Can I ask you to have a look what's missing? THX
There was a problem hiding this comment.
I took a look but it indeed does not seem to be triggered anymore. Maybe there was a different bug. Anyway good it is fixed.
There was a problem hiding this comment.
Maybe related to an older version. Let's close this for now - let us know if the issue pops up again. THX
DeepDiver1975
force-pushed
the
rullzer-prevent_inf_loop
branch
from
615a77d
to
cd360d3
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #70