Throw exception when empty inputs found #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When input retrieved from stream_get_contents is empty string, then it would be safe to throw exceptions from the parse and expect methods. Signed-off-by: Sujith H <sharidasan@owncloud.com>
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
===========================================
+ Coverage 97.58% 97.6% +0.02%
- Complexity 112 114 +2
===========================================
Files 13 13
Lines 456 460 +4
===========================================
+ Hits 445 449 +4
Misses 11 11
Continue to review full report at Codecov.
|
|
@staabm mind reviewing? THX |
staabm
reviewed
Nov 5, 2019
|
|
||
| // If input is an empty string, then its safe to throw exception | ||
| if ('' === $input) { | ||
| throw new ParseException('The input element to parse is empty. Do not attempt to parse'); |
There was a problem hiding this comment.
not sure I get the meaning of this error message? what do you try to tell the caller?
staabm
reviewed
Nov 5, 2019
| @@ -115,6 +115,11 @@ public function parse($input, string $contextUri = null, string &$rootElementNam | |||
| // Unfortunately the XMLReader doesn't support streams. When it | |||
| // does, we can optimize this. | |||
| $input = (string) stream_get_contents($input); | |||
|
|
|||
| // If input is an empty string, then its safe to throw exception | |||
There was a problem hiding this comment.
we should mention that we get into an infinite loop when we don't throw
staabm
approved these changes
Nov 5, 2019
|
FYI - this is just the merge of the original PR which targeted 2.1 - see #166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When input retrieved from stream_get_contents
is empty string, then it would be safe to throw
exceptions from the parse and expect methods.
Signed-off-by: Sujith H sharidasan@owncloud.com
master version of #166