Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with PHP8.0 #190

Merged
merged 4 commits into from Oct 3, 2020
Merged

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Oct 3, 2020

  1. sort out variables in .travis.yml for selecting to run php-cs-fixer, phpunit and phpstan
  2. Add a matrix entry to run just phpunit on Ubuntu 20.04 "focal" with "nightly" PHP (which is the way to get PHP 8.0 at the moment)
  3. When not running php-cs-fixer, explicitly remove it from composer.json (because php-cs-fixer does not yet support PHP 8.0, so composer cannot sort out dependencies if we have PHP 8.0 and php-cs-fixer 2.* together)
  4. libxml_disable_entity_loader is deprecated on PHP 8.0. This is already disabled on PHP 8.0, so this function does not need to be called. Put a conditional check around it. https://php.watch/versions/8.0/libxml_disable_entity_loader-deprecation

Relates to sabre-io/vobject#513

@phil-davis phil-davis self-assigned this Oct 3, 2020
@codecov
Copy link

codecov bot commented Oct 3, 2020

Codecov Report

Merging #190 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #190      +/-   ##
============================================
+ Coverage     97.61%   97.65%   +0.04%     
- Complexity      112      116       +4     
============================================
  Files            13       13              
  Lines           461      469       +8     
============================================
+ Hits            450      458       +8     
  Misses           11       11              
Impacted Files Coverage Δ Complexity Δ
lib/Reader.php 99.16% <100.00%> (+0.03%) 46.00 <0.00> (+3.00)
lib/Writer.php 100.00% <0.00%> (ø) 19.00% <0.00%> (ø%)
lib/Service.php 100.00% <0.00%> (ø) 18.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41c6ba1...446ded7. Read the comment docs.

lib/Reader.php Show resolved Hide resolved
Copy link
Member

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thanks

@phil-davis phil-davis marked this pull request as ready for review October 3, 2020 08:37
@phil-davis phil-davis merged commit cb378d8 into sabre-io:master Oct 3, 2020
@phil-davis phil-davis deleted the test-with-php-8.0 branch October 3, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants