Cs fixer CI changes v3 #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v3 #239 +/- ##
============================================
+ Coverage 96.68% 96.90% +0.21%
Complexity 116 116
============================================
Files 13 13
Lines 453 485 +32
============================================
+ Hits 438 470 +32
Misses 15 15
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
After PR #238 is merged, I will sort this out to make similar changes for major version 3. |
|
@staabm this gets the major version 3 branch up-to-date with all the tools... |
staabm
approved these changes
Jun 28, 2023
staabm
reviewed
Jun 28, 2023
| @@ -30,9 +29,9 @@ class LibXMLException extends ParseException | |||
| * | |||
| * You should pass a list of LibXMLError objects in its constructor. | |||
| * | |||
| * @param LibXMLError[] $errors | |||
| * @param \LibXMLError[] $errors | |||
There was a problem hiding this comment.
interessting that these got prefixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php-cs-fixer now wants various changes.
I have got most of this from what is in master branch (major version 4) and applied it to the major version 3 branch. See master PRs #231 #233 #234 #236 #238