Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance PHPdoc of Service write value parameter #247

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

phil-davis
Copy link
Contributor

Fixes #237

This makes the PHPdoc of Service write allow an array with integer keys to be passed in the value parameter.
That is passed to:
$w->writeElement($rootElementName, $value);

And Writer writeElement already has PHPdoc that allows array<int|string, mixed>

@phil-davis phil-davis self-assigned this Jun 28, 2023
@phil-davis phil-davis requested a review from staabm June 28, 2023 13:22
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #247 (c2547e2) into master (c4cec17) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #247   +/-   ##
=========================================
  Coverage     96.90%   96.90%           
  Complexity      116      116           
=========================================
  Files            13       13           
  Lines           485      485           
=========================================
  Hits            470      470           
  Misses           15       15           
Impacted Files Coverage Δ
lib/Service.php 98.59% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@phil-davis phil-davis merged commit d7cad5f into sabre-io:master Jun 28, 2023
6 checks passed
@phil-davis phil-davis deleted the fix-237 branch June 28, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type annotation for Service::write() is not correct
2 participants