Fix wrong reference to fastapi-mail and typos in contributing.md #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azogue
requested changes
Sep 25, 2023
There was a problem hiding this comment.
Hi @KrappRamiro, thanks for contributing 🙏
Could you check the comment for the FIXME?
Everything else is great, and ready to merge. I would only substitute the usages of 'mqtt' with 'MQTT', to make it perfect 😜
|
Hi @KrappRamiro, thanks for the PR, I took it from my other module at the initial start, thanks for fixing :) I will approve PR, @azogue has a comment please take a look, thanks! |
azogue
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributing.mdtalked aboutfastapi-mailinstead offastapi-mqtt. That was fixed by changing the text and updating the urlsAlso, the
### Before get in to the repo and typesection looks a bit weird, i dont understand the purpose. Maybe it had sense infastapi-mail?