Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lg-video module has iFrame with http protocol #758

Closed
asso1985 opened this issue Feb 23, 2018 · 1 comment
Closed

lg-video module has iFrame with http protocol #758

asso1985 opened this issue Feb 23, 2018 · 1 comment

Comments

@asso1985
Copy link

Hi,

Using the httpschecker Tool (https://httpschecker.net/) we are running into non-secure protocol issues because of the current inclusion in lg-video module:

video = '<iframe class="lg-video-object lg-vk ' + addClass + '" width="560" height="315" src="http://vk.com/video_ext.php?' + isVideo.vk[1] + a + '" frameborder="0" allowfullscreen></iframe>';
line 138

Can this be changed in a future release as per all the others default values you have there excluding the protocol ?

ex

video = '<iframe class="lg-video-object lg-dailymotion ' + addClass + '" width="560" height="315" src="//www.dailymotion.com/embed/video/' + isVideo.dailymotion[1] + a + '" frameborder="0" allowfullscreen></iframe>';
line 121

I can even open a PR if needed, its a very very tiny change :)

Thanks in advance and thanks for the great job with the lib overall

sachinchoolur added a commit to sachinchoolur/lg-video that referenced this issue Mar 8, 2018
@sachinchoolur
Copy link
Owner

Hey @asso1985,

Thank you for pointing this out. The issue has been fixed. Please use the latest version of lightGallery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants