Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation warning #47

Closed
yanivshaked opened this issue Jun 13, 2021 · 3 comments
Closed

Compilation warning #47

yanivshaked opened this issue Jun 13, 2021 · 3 comments

Comments

@yanivshaked
Copy link
Contributor

Note the following compilation warning; delay is not nullable so the ?? operation is redundant.

/C:/src/flutter/.pub-cache/hosted/pub.dartlang.org/screenshot-1.1.0/lib/screenshot.dart:45:31: Warning: Operand of null-aware operation '??' has type 'Duration' which excludes null.
 - 'Duration' is from 'dart:core'.
    return new Future.delayed(delay ?? Duration(milliseconds: 20), () async {
@armandojimenez
Copy link

Same issue

@yanivshaked
Copy link
Contributor Author

The accepted PR #48 fixes this issue, @SachinGanesh can you please release a new version?

@SachinGanesh
Copy link
Owner

Fixed in version 1.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SachinGanesh @yanivshaked @armandojimenez