Merge pull request #33 from david-waltermire-nist/sec-ad-feedback

CoSWID AD review edits
Looks good, will check build chain to be on the safe side

Makefile

@@ -7,5 +7,5 @@ ifneq (,$(shell grep "path *= *$(LIBDIR)" .gitmodules 2>/dev/null))
 	git submodule update $(CLONE_ARGS) --init
 else
 	git clone -q --depth 10 $(CLONE_ARGS) \
-	    -b master https://github.com/martinthomson/i-d-template $(LIBDIR)
+	    -b main https://github.com/martinthomson/i-d-template $(LIBDIR)
 endif

concise-swid-tag.cddl

@@ -1,5 +1,4 @@
 concise-swid-tag = {
-  global-attributes,
   tag-id => text / bstr .size 16,
   tag-version => integer,
   ? corpus => bool,
@@ -13,6 +12,7 @@ concise-swid-tag = {
   entity => entity-entry / [ 2* entity-entry ],
   ? link => link-entry / [ 2* link-entry ],
   ? payload-or-evidence,
+  global-attributes,
   * $$coswid-extension,
 }
 
@@ -46,11 +46,11 @@ hash-entry = [
 ]
 
 entity-entry = {
-  global-attributes,
   entity-name => text,
   ? reg-id => any-uri,
   role => $role / [ 2* $role ],
   ? thumbprint => hash-entry,
+  global-attributes,
   * $$entity-extension,
 }
 
@@ -63,14 +63,14 @@ $role /= maintainer
 $role /= uint / text
 
 link-entry = {
-  global-attributes,
   ? artifact => text,
   href => any-uri,
   ? media => text,
   ? ownership => $ownership,
   rel => $rel,
   ? media-type => text,
   ? use => $use,
+  global-attributes,
   * $$link-extension
 }
 
@@ -90,15 +90,14 @@ $rel /= requires
 $rel /= see-also
 $rel /= supersedes
 $rel /= supplemental
-$rel /= uint / text
+$rel /= -256..64436 / text
 
 $use /= optional
 $use /= required
 $use /= recommended
 $use /= uint / text
 
 software-meta-entry = {
-  global-attributes,
   ? activation-status => text,
   ? channel-type => text,
   ? colloquial-version => text,
@@ -114,6 +113,7 @@ software-meta-entry = {
   ? summary => text,
   ? unspsc-code => text,
   ? unspsc-version => text,
+  global-attributes,
   * $$software-meta-extension,
 }
 
@@ -143,37 +143,37 @@ directory-entry = {
 }
 
 process-entry = {
-  global-attributes,
   process-name => text,
   ? pid => integer,
+  global-attributes,
   * $$process-extension,
 }
 
 resource-entry = {
-  global-attributes,
   type => text,
+  global-attributes,
   * $$resource-extension,
 }
 
 filesystem-item = (
-  global-attributes,
   ? key => bool,
   ? location => text,
   fs-name => text,
   ? root => text,
+  global-attributes,
 )
 
 payload-entry = {
-  global-attributes,
   resource-collection,
+  global-attributes,
   * $$payload-extension,
 }
 
 evidence-entry = {
-  global-attributes,
   resource-collection,
   ? date => time,
   ? device-id => text,
+  global-attributes,
   * $$evidence-extension, 
 }