-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CoSWID AD review edits #33
Merged
Merged
Commits on Oct 26, 2020
-
** Section 1. Per the remote attestation use case, would the RATS architecture draft be more appropriate than [I-D.birkholz-rats-tuda]?
Configuration menu - View commit details
-
Copy full SHA for 37c75fd - Browse repository at this point
Copy the full SHA 37c75fdView commit details -
the Corpus tag appears to have no change of state -- get removed at all during the Lifecycle?
Configuration menu - View commit details
-
Copy full SHA for c9f9541 - Browse repository at this point
Copy the full SHA c9f9541View commit details -
** Section 1.1. Editorial. After reading this section, I was wondering about what's the difference between patching and upgrading? Does one bump the version number and the other does not? Perhaps a forward reference to Section 2.3 would be appropriate here.
Configuration menu - View commit details
-
Copy full SHA for c4731db - Browse repository at this point
Copy the full SHA c4731dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc5aa6b - Browse repository at this point
Copy the full SHA fc5aa6bView commit details -
** Section 2.3. Global Typo. s/section Section/Section/g
Configuration menu - View commit details
-
Copy full SHA for 7f543f6 - Browse repository at this point
Copy the full SHA 7f543f6View commit details -
** Section 2.3. Per "This item represents a query as defined by the W3C Media Queries Recommendation (see [W3C.REC-css3-mediaqueries-20120619])" can normative language be applied here to constrain the format. Perhaps "This item MUST be formatted as query defined by the W3C Media Queries Recommendation (see [W3C.REC-css3-mediaqueries-20120619]) format.
Configuration menu - View commit details
-
Copy full SHA for fa9bf77 - Browse repository at this point
Copy the full SHA fa9bf77View commit details -
** Section 2.6 Editorial. s/an registration ID/a registration ID/ ** Section 2.6. Per "In a given scope, the registration id MUST be used consistently for CoSWID tag production.", can you clarify what you mean by consistently?
Configuration menu - View commit details
-
Copy full SHA for 5f9db41 - Browse repository at this point
Copy the full SHA 5f9db41View commit details -
** Section 2.7. Typo. s/a Ownership/an Ownership/ ** Section 2.7. Typo. s/Link Use Value Value/Link Use Value/ ** Section 2.8. Typo. s/identfies/identifies/ ** Section 2.8. unspsc-code. Please cite the URL of unspsc.org by reference.
Configuration menu - View commit details
-
Copy full SHA for 585dc58 - Browse repository at this point
Copy the full SHA 585dc58View commit details -
** Section 2.9.1. Should the Status field of the Named Information Hash Algorithm Registry be considered when choosing an appropriate hash algorithm?
Configuration menu - View commit details
-
Copy full SHA for ea269a4 - Browse repository at this point
Copy the full SHA ea269a4View commit details -
** Section 4.1. Typo. s/gudelines/guidelines/ ** Section 4.1. Editorial. s/decimal number ./decimal number./ ** Section 5.2.1. Typo. s/Proceedures/Procedures/ ** Section 5.3. Editorial. s/RFC-7049/[RFC7049] not fixed but first pass: ** Section 5.6.1 and 5.6.2. Please use the template described in Section 7.4 of RFC 7595. The fields below are part of the "old template".
Configuration menu - View commit details
-
Copy full SHA for 876db8b - Browse repository at this point
Copy the full SHA 876db8bView commit details -
** Section 5.6.1. Typo. s/speific/specific/ ** Section 5.6.1. Global Typo. s/indentify/identify/g ** Section 5.7. Typo. s/ietm/item/ ** Section 6. Per "When an authoritative tag is signed, the software provider can be authenticated as the originator of the signature", what is the binding between the software provider and the key used to provide the signature? Put in another way, how do I know the signature on the CoSWID really belongs to the software provider? Same for a supplementary tag?
Configuration menu - View commit details
-
Copy full SHA for e2d6831 - Browse repository at this point
Copy the full SHA e2d6831View commit details -
** Section 6. "collected from an endpoint in transit and at rest" ** Section 6. Per "For this reason, tools that consume SWID/CoSWID tags ought to treat ...", is normative language or less colloquial language more appropriate here - s/ought/should/?
Configuration menu - View commit details
-
Copy full SHA for 937c84a - Browse repository at this point
Copy the full SHA 937c84aView commit details
Commits on Oct 28, 2020
-
edits to partially address AD review feedback from Roman Danyliw, wit…
…h specific focus on SWID/CoSWID issues
Configuration menu - View commit details
-
Copy full SHA for bb0cf7c - Browse repository at this point
Copy the full SHA bb0cf7cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 74bfc5e - Browse repository at this point
Copy the full SHA 74bfc5eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7518adc - Browse repository at this point
Copy the full SHA 7518adcView commit details
Commits on Nov 2, 2020
-
Addressing most issues on github sans the combination of Section on h…
…ash with Section in resource-collection
Configuration menu - View commit details
-
Copy full SHA for 7b23b52 - Browse repository at this point
Copy the full SHA 7b23b52View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.