Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoSWID AD review edits #33

Merged
merged 16 commits into from
Nov 2, 2020
Merged

Commits on Oct 26, 2020

  1. addresses:

    ** Section 1.  Per the remote attestation use case, would the RATS architecture draft be more appropriate than [I-D.birkholz-rats-tuda]?
    henkbirkholz committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    37c75fd View commit details
    Browse the repository at this point in the history
  2. addresses:

    the Corpus tag appears to have no change of state -- get removed at all during the Lifecycle?
    henkbirkholz committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    c9f9541 View commit details
    Browse the repository at this point in the history
  3. addresses:

    ** Section 1.1.  Editorial.  After reading this section, I was wondering about what's the difference between patching and upgrading?  Does one bump the version number and the other does not?  Perhaps a forward reference to Section 2.3 would be appropriate here.
    henkbirkholz committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    c4731db View commit details
    Browse the repository at this point in the history
  4. addresses:

    ** Section 2.1.  Recommend using normative language:
    henkbirkholz committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    fc5aa6b View commit details
    Browse the repository at this point in the history
  5. addresses:

    ** Section 2.3. Global Typo. s/section Section/Section/g
    henkbirkholz committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    7f543f6 View commit details
    Browse the repository at this point in the history
  6. addresses:

    ** Section 2.3.  Per "This item represents a query as defined by the W3C Media Queries     Recommendation (see [W3C.REC-css3-mediaqueries-20120619])" can normative language be applied here to constrain the format.  Perhaps "This item MUST be formatted as query defined by the W3C Media Queries Recommendation (see [W3C.REC-css3-mediaqueries-20120619]) format.
    henkbirkholz committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    fa9bf77 View commit details
    Browse the repository at this point in the history
  7. addresses:

    ** Section 2.6 Editorial.  s/an registration ID/a registration ID/
    ** Section 2.6.  Per "In a given scope, the registration id MUST be used consistently for CoSWID tag production.", can you clarify what you mean by consistently?
    henkbirkholz committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    5f9db41 View commit details
    Browse the repository at this point in the history
  8. addresses:

    ** Section 2.7. Typo. s/a Ownership/an Ownership/
    ** Section 2.7.  Typo. s/Link Use Value Value/Link Use Value/
    ** Section 2.8.  Typo. s/identfies/identifies/
    ** Section 2.8.  unspsc-code.  Please cite the URL of unspsc.org by reference.
    henkbirkholz committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    585dc58 View commit details
    Browse the repository at this point in the history
  9. addresses:

    ** Section 2.9.1.  Should the Status field of the Named Information Hash Algorithm Registry be considered when choosing an appropriate hash algorithm?
    henkbirkholz committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    ea269a4 View commit details
    Browse the repository at this point in the history
  10. addresses:

    ** Section 4.1. Typo. s/gudelines/guidelines/
    ** Section 4.1. Editorial. s/decimal number ./decimal number./
    ** Section 5.2.1. Typo. s/Proceedures/Procedures/
    ** Section 5.3.  Editorial. s/RFC-7049/[RFC7049]
    
    not fixed but first pass:
    
    ** Section 5.6.1 and 5.6.2.  Please use the template described in Section 7.4 of RFC 7595.  The fields below are part of the "old template".
    henkbirkholz committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    876db8b View commit details
    Browse the repository at this point in the history
  11. addresses:

    ** Section 5.6.1.  Typo. s/speific/specific/
    ** Section 5.6.1.  Global Typo. s/indentify/identify/g
    ** Section 5.7.  Typo. s/ietm/item/
    ** Section 6.  Per "When an authoritative tag is signed, the software provider can be authenticated as the originator of the signature", what is the binding between the software provider and the key used to provide the signature?  Put in another way, how do I know the signature on the CoSWID really belongs to the software provider?  Same for a supplementary tag?
    henkbirkholz committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    e2d6831 View commit details
    Browse the repository at this point in the history
  12. addressed:

    ** Section 6. "collected from an endpoint in transit and at rest"
    ** Section 6.  Per "For this reason, tools that consume SWID/CoSWID tags ought to treat ...", is normative language or less colloquial language more appropriate here - s/ought/should/?
    henkbirkholz committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    937c84a View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2020

  1. edits to partially address AD review feedback from Roman Danyliw, wit…

    …h specific focus on SWID/CoSWID issues
    david-waltermire committed Oct 28, 2020
    Configuration menu
    Copy the full SHA
    bb0cf7c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    74bfc5e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7518adc View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2020

  1. Addressing most issues on github sans the combination of Section on h…

    …ash with Section in resource-collection
    henkbirkholz authored and david-waltermire committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    7b23b52 View commit details
    Browse the repository at this point in the history