reordering of global-attribute in text and full cddl #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduced the quantity of evidence or payload to one changed any-uri from text to uri
cabo
reviewed
Feb 18, 2021
| } | ||
|
|
||
| payload-or-evidence //= ( payload => payload-entry ) | ||
| payload-or-evidence //= ( payload => [ 2* payload-entry ] ) |
There was a problem hiding this comment.
Is this an unrelated change?
There was a problem hiding this comment.
yes, that is a change that leaked over from the "isomorphic issue"
cabo
reviewed
Feb 18, 2021
concise-swid-tag.cddl
Outdated
| } | ||
|
|
||
| evidence-entry = { | ||
| resource-collection, | ||
| ? date => time, | ||
| ? date => #6.1(int), |
There was a problem hiding this comment.
I think it would be better style to add a
integer-time = #6.1(int)
and reference that here.
cabo
reviewed
Feb 18, 2021
|
|
||
| any-uri = text | ||
| any-uri = uri |
cabo
changed the title
henkbirkholz
commented
Feb 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #29