Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconcistencies, markdown usage #40

Merged
merged 4 commits into from Feb 22, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions check-cddl.sh
@@ -0,0 +1,3 @@
kdrfc -3 draft-ietf-sacm-coswid.md
LANG=C xpath draft-ietf-sacm-coswid.xml "//sourcecode[@type='CDDL']/text()" >.extracted.cddl
cddl .extracted.cddl g
6 changes: 3 additions & 3 deletions concise-swid-tag.cddl
Expand Up @@ -38,7 +38,7 @@ global-attributes = (
* any-attribute,
)

hash-entry = [
hash-entry = [
hash-alg-id: int,
hash-value: bytes,
]
Expand Down Expand Up @@ -68,7 +68,7 @@ link-entry = {
rel => $rel,
? media-type => text,
? use => $use,
* $$link-extension
* $$link-extension,
global-attributes,
}

Expand Down Expand Up @@ -172,7 +172,7 @@ evidence-entry = {
resource-collection,
? date => integer-time,
? device-id => text,
* $$evidence-extension,
* $$evidence-extension,
global-attributes,
}

Expand Down
21 changes: 9 additions & 12 deletions draft-ietf-sacm-coswid.md
Expand Up @@ -54,7 +54,6 @@ author:
normative:
BCP26: RFC8126
BCP178: RFC6648
RFC2119:
RFC3629:
RFC3986:
RFC5198:
Expand Down Expand Up @@ -473,7 +472,7 @@ The CDDL for the global-attributes follows:

~~~ CDDL
global-attributes = (
? lang,
? lang => text,
* any-attribute,
)

Expand Down Expand Up @@ -768,21 +767,22 @@ filesystem-item = (
? location => text,
fs-name => text,
? root => text,
global-attributes,
)

file-entry = {
filesystem-item,
? size => integer,
? size => uint,
? file-version => text,
? hash => hash-entry,
* $$file-extension,
global-attributes,
}

directory-entry = {
filesystem-item,
path-elements => { path-elements-group },
? path-elements => { path-elements-group },
* $$directory-extension,
global-attributes,
}

process-entry = {
Expand Down Expand Up @@ -887,7 +887,7 @@ The CDDL for the evidence-entry map follows:
~~~ CDDL
evidence-entry = {
resource-collection,
? date => time,
? date => integer-time,
? device-id => text,
* $$evidence-extension,
global-attributes,
Expand Down Expand Up @@ -917,10 +917,9 @@ In order to create a valid CoSWID document the structure of the corresponding CB
adhere to the following CDDL specification.

~~~ CDDL
<CODE BEGINS>
{::include concise-swid-tag.cddl}
<CODE ENDS>
~~~
{: markers="true"}

{: #semantics-tag-type}
# Determining the Type of CoSWID
Expand Down Expand Up @@ -1519,18 +1518,16 @@ The ISO-19770-2:2015 XML schema uses XML DSIG to support cryptographic signature
Signing CoSWID tags follows the procedues defined in CBOR Object Signing and Encryption {{RFC8152}}. A CoSWID tg MUST be wrapped in a COSE Single Signer Data Object (COSE_Sign1) that contains a single signature and MUST be signed by the tag creator. The following CDDL specification defines a restrictive subset of COSE header parameters that MUST be used in the protected header.

~~~~ CDDL
<CODE BEGINS>
{::include signed-coswid.cddl}
<CODE ENDS>
~~~~
{: markers="true"}

The COSE_Sign structure that allows for more than one signature to be applied to a CoSWID tag MAY be used. The corresponding usage scenarios are domain-specific and require well-specified application guidance.

~~~~ CDDL
<CODE BEGINS>
{::include signed-coswid_sign.cddl}
<CODE ENDS>
~~~~
{: markers="true"}

Additionally, the COSE Header counter signature MAY be used as an attribute in the unprotected header map of the COSE envelope of a CoSWID. The application of counter signing enables second parties to provide a signature on a signature allowing for a proof that a signature existed at a given time (i.e., a timestamp).

Expand Down