fix(storefront): BCTHEME-400 If product options are not required, the…

… 'None' option will remain selected even if another option is chosen (bigcommerce#1980)
sacr3dc0w · Mar 31, 2021 · 16bdeb7 · 16bdeb7
1 parent 95aea47
commit 16bdeb7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 # Changelog
 
 ## Draft
+- For non-required options, when the "None" option displays on the storefront it should be deselected when another option is chosen. [#1980](https://github.com/bigcommerce/cornerstone/pull/1980)
 - Error message not announced automatically. [#1983](https://github.com/bigcommerce/cornerstone/pull/1983)
 - Fixed Discount Banner update on adding item to Cart from PDP [#1974](https://github.com/bigcommerce/cornerstone/pull/1974)
 - Make every product option group id unique. [#1979](https://github.com/bigcommerce/cornerstone/pull/1979)

diff --git a/templates/components/products/options/set-radio.html b/templates/components/products/options/set-radio.html
@@ -9,12 +9,12 @@
         <input
             class="form-radio"
             type="radio"
-            id="attribute_radio_{{../id}}_none"
-            name="attribute[{{../id}}]"
+            id="attribute_radio_{{id}}_none"
+            name="attribute[{{id}}]"
             value=""
             checked="{{#if defaultValue '==' ''}}checked{{/if}}"
         >
-        <label class="form-label" for="attribute_radio_{{../id}}_none">{{lang 'products.none'}}</label>
+        <label class="form-label" for="attribute_radio_{{id}}_none">{{lang 'products.none'}}</label>
     {{/unless}}
 
     {{#each this.values}}