Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flashloan fee check #345

Merged
merged 3 commits into from
Apr 7, 2021
Merged

Conversation

guoyiteng
Copy link
Contributor

As I reported in #344, this fee check is wrong. You can reproduce it by running the unit test in this PR.

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #345 (583173f) into master (b0c731c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #345   +/-   ##
=======================================
  Coverage   99.40%   99.40%           
=======================================
  Files          10       10           
  Lines         505      505           
  Branches       85       85           
=======================================
  Hits          502      502           
  Misses          3        3           
Impacted Files Coverage Δ
contracts/SwapFlashLoan.sol 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c731c...583173f. Read the comment docs.

penandlim
penandlim previously approved these changes Apr 7, 2021
@penandlim penandlim merged commit b096d07 into saddle-finance:master Apr 7, 2021
@alphastorm
Copy link
Collaborator

Hi @guoyiteng, thanks for filing this PR!

We recently launched a bug bounty program on Immunefi and even though this was reported prior, we'd like to honor it as a low level report with a $1,000 USDC bounty (classified per the Immunefi Vulnerability Severity Classification System).

Could you please join our Discord and message alphast0rm#3577 to coordinate? Thanks again!

@guoyiteng
Copy link
Contributor Author

Thank you so much for the bouty! I was thinking that my bug report timing was bad and I missed the bounty. I'm glad that you can honor it. To verify my identity in discord, the secret word is 1337.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants