Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad use of transition #15

Open
MetaX5 opened this issue Jun 29, 2023 · 2 comments
Open

Bad use of transition #15

MetaX5 opened this issue Jun 29, 2023 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@MetaX5
Copy link

MetaX5 commented Jun 29, 2023

skateshop/src/components/generate-button.tsx

Line 16 in aaa1b21

startTransition(async () => {

"The function you pass to startTransition must be synchronous."
https://react.dev/reference/react/useTransition#react-doesnt-treat-my-state-update-as-a-transition
@sadmann7
Copy link
Owner

sadmann7 commented Jul 1, 2023

Sophie from the react team said it will be changed soon. Things are working ok right now with async transactions.

Here is a tweet thread if you wanna learn more about transaction:
https://twitter.com/sadmann17/status/1672417150378860544

@sadmann7
Copy link
Owner

sadmann7 commented Jul 1, 2023

Duplicate of #1

@sadmann7 sadmann7 marked this as a duplicate of #1 Jul 1, 2023
@sadmann7 sadmann7 added the duplicate This issue or pull request already exists label Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sadmann7 @MetaX5