-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.1 #13
Version 1.1 #13
Conversation
New Examples from Lawler
Input state type support and minor issue solved
@sepandhaghighi |
- all input `state` type support | ||
### Changes | ||
- `make_prob_dist` modified | ||
- new examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better if move this line and the 2 lines below to the ### Added
section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you're right.
That issue occurred when merging.
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 128 153 +25
Branches 22 31 +9
=========================================
+ Hits 128 153 +25
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
"/usr/lib/python3/dist-packages/secretstorage/dhcrypto.py:15: CryptographyDeprecationWarning: int_from_bytes is deprecated, use int.from_bytes instead\r\n", | ||
" from cryptography.utils import int_from_bytes\r\n", | ||
"/usr/lib/python3/dist-packages/secretstorage/util.py:19: CryptographyDeprecationWarning: int_from_bytes is deprecated, use int.from_bytes instead\r\n", | ||
" from cryptography.utils import int_from_bytes\r\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at this warning in the next release!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's ODD. which function is using this? 😄
Reference Issues/PRs
close #8
related to #9 and #2
Added
state
type supportChanges
make_prob_dist
modifiedpaper.bib
paper.md