Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.1 #13

Merged
merged 30 commits into from
Aug 24, 2021
Merged

Version 1.1 #13

merged 30 commits into from
Aug 24, 2021

Conversation

sadrasabouri
Copy link
Owner

Reference Issues/PRs

close #8
related to #9 and #2

Added

  • all input state type support

Changes

  • make_prob_dist modified
  • new examples
  • paper.bib
  • paper.md

@sadrasabouri
Copy link
Owner Author

sadrasabouri commented Aug 23, 2021

@sepandhaghighi
If you have time, it would be nice if you leave a review for this version until 26th August.
But feel free it's not that much important.

- all input `state` type support
### Changes
- `make_prob_dist` modified
- new examples
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better if move this line and the 2 lines below to the ### Added section

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you're right.
That issue occurred when merging.

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2021

Codecov Report

Merging #13 (71a6eac) into master (f39947b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          128       153   +25     
  Branches        22        31    +9     
=========================================
+ Hits           128       153   +25     
Impacted Files Coverage Δ
pyrandwalk/pyrandwalk_error.py 100.00% <ø> (ø)
pyrandwalk/pyrandwalk_obj.py 100.00% <100.00%> (ø)
pyrandwalk/pyrandwalk_param.py 100.00% <100.00%> (ø)
pyrandwalk/pyrandwalk_util.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b26bb85...71a6eac. Read the comment docs.

Copy link
Collaborator

@sepandhaghighi sepandhaghighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

"/usr/lib/python3/dist-packages/secretstorage/dhcrypto.py:15: CryptographyDeprecationWarning: int_from_bytes is deprecated, use int.from_bytes instead\r\n",
" from cryptography.utils import int_from_bytes\r\n",
"/usr/lib/python3/dist-packages/secretstorage/util.py:19: CryptographyDeprecationWarning: int_from_bytes is deprecated, use int.from_bytes instead\r\n",
" from cryptography.utils import int_from_bytes\r\n"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at this warning in the next release!

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's ODD. which function is using this? 😄

@sadrasabouri sadrasabouri merged commit eebfe53 into master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add string type state support
3 participants