-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SessionsController's create action to send all the initial props to the Miru desktop app as login response #1449
Merged
prasanthchaduvula
merged 9 commits into
develop
from
MiruDesktop/send-initial-props-as-login-response-to-miru-desktop-app
Nov 29, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ps to Miru desktop app as login response
…esponse-to-miru-desktop-app
…esponse-to-miru-desktop-app
…esponse-to-miru-desktop-app
…esponse-to-miru-desktop-app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanjibroy360 Let me test this out and will get back to you
…esponse-to-miru-desktop-app
@sanjibroy360 I went through the changes and will try to push a change to avoid the skipping of skip_before_action :verify_authenticity_token, only: :create |
prasanthchaduvula
approved these changes
Nov 29, 2023
prasanthchaduvula
deleted the
MiruDesktop/send-initial-props-as-login-response-to-miru-desktop-app
branch
November 29, 2023 10:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
?app=miru_desktop
param otherwise it'll send the regular login response.Why