Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SessionsController's create action to send all the initial props to the Miru desktop app as login response #1449

Conversation

sanjibroy360
Copy link
Contributor

What

  • Update SessionsController's create action to send all the initial props to the Miru desktop app as login response and also added specs for this change.
  • It'll send the initial props as a response only when it has the ?app=miru_desktop param otherwise it'll send the regular login response.

Why

  • To get the avatar_url and other initial props on the Miru desktop app as well.

Copy link
Contributor

@prasanthchaduvula prasanthchaduvula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanjibroy360 Let me test this out and will get back to you

@sanjibroy360 sanjibroy360 removed the WIP label Nov 24, 2023
@prasanthchaduvula
Copy link
Contributor

@sanjibroy360 I went through the changes and will try to push a change to avoid the skipping of skip_before_action :verify_authenticity_token, only: :create

@prasanthchaduvula prasanthchaduvula merged commit 1886101 into develop Nov 29, 2023
1 check passed
@prasanthchaduvula prasanthchaduvula deleted the MiruDesktop/send-initial-props-as-login-response-to-miru-desktop-app branch November 29, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants