Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show payment entry modal on invoice page #1576

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

apoorv1316
Copy link
Contributor

What

  • Show payment entry modal onClick on the "Mark as paid" option on the Invoice page

Why

  • For better UX. Earlier it used to redirect to the payments page

Loom:
https://www.loom.com/share/45ca4e3552ad40f191fb9373379727d6

Copy link
Contributor

@supriya3105 supriya3105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good .
There is a minor change required. The first field on the modal is displaying the client name whereas it should display the invoice number as well.
However that is an existing issue which we can fix in separate PR.

@apoorv1316 apoorv1316 merged commit 631b37f into develop Nov 2, 2023
1 check passed
@apoorv1316 apoorv1316 deleted the payment-entry-modal-invoice-page branch November 2, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants