Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed populating emails on send invoice #1598

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Fixed populating emails on send invoice #1598

merged 2 commits into from
Nov 28, 2023

Conversation

prasanthchaduvula
Copy link
Contributor

What

  • Updated the API response to include virtual verified emails and client contact emails for generate invoice.
  • Made a common SendInvoice component and used it on the generate, edit, view and invoice list page.
  • Removed the duplicate send invoice components.

apoorv1316
apoorv1316 reviewed Nov 28, 2023
View reviewed changes
Copy link
Contributor

@apoorv1316 apoorv1316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prasanthchaduvula Please work on mobile devices fixes too.

@apoorv1316 apoorv1316 merged commit fb660d4 into develop Nov 28, 2023
1 check passed
@apoorv1316 apoorv1316 deleted the fix-send-invoice-email-population branch November 28, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorv1316 apoorv1316 apoorv1316 approved these changes

Assignees

@prasanthchaduvula prasanthchaduvula

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prasanthchaduvula @apoorv1316