Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include TimeoffEntry duration along with TimesheetEntry duration for weekly reminder job #1660

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Include TimeoffEntry duration along with TimesheetEntry duration for weekly reminder job #1660

merged 3 commits into from
Feb 5, 2024

Conversation

nisusam
Copy link
Contributor

@nisusam nisusam commented Jan 29, 2024

  • Recently we moved PTO, Holidays, and Optional Holidays to TimeoffEntry
  • After this, we must include these entries while sending weekly reminder emails
  • Currently, this email is sent every Monday if the past week has less than 40 hours of work

Include TimeoffEntry duration along with TimesheetEntry duration for …
7a65092 
…weekly reminder job

- Recently we moved PTO, Holidays and Optional Holidays to `TimeoffEntry`
- After this, we must include these entries while sending weekly reminder emails
- Currently this email sent every Monday if past week has less than 40
  hours of work
@prasanthchaduvula prasanthchaduvula merged commit 646fe73 into develop Feb 5, 2024
1 check passed
@prasanthchaduvula prasanthchaduvula deleted the weekly_reminder_fixes branch February 5, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prasanthchaduvula prasanthchaduvula prasanthchaduvula approved these changes

@JijoBose JijoBose Awaiting requested review from JijoBose

@apoorv1316 apoorv1316 Awaiting requested review from apoorv1316

@harshaanNihal harshaanNihal Awaiting requested review from harshaanNihal

@gowsik-ragunath gowsik-ragunath Awaiting requested review from gowsik-ragunath

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nisusam @prasanthchaduvula