Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace safe_email to with email in factories #1685

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Replace safe_email to with email in factories #1685

merged 2 commits into from
Mar 4, 2024

Conversation

apoorv1316
Copy link
Contributor

Why

  • safe_email is deprecated

nisusam
nisusam approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@nisusam nisusam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix failing spec. Rest LGTM!

@apoorv1316 apoorv1316 merged commit b566712 into develop Mar 4, 2024
1 check passed
@apoorv1316 apoorv1316 deleted the use-email-faker branch March 4, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nisusam nisusam nisusam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@apoorv1316 @nisusam