-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Stripe for specific Invoice for desktop #1692
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Show `settings` gear icon to open `InvoiceSettings` modal
- Fix condition to show `StripeDisabled` modal - Send updated value of `stripe_enabled` in edit form - Move `InvoiceSettings` sidebar to higher level to use it in both `Generate Invoice` and `Edit Invoice` screens - Send `stripe_enabled` value in API response
gowsik-ragunath
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes
app/javascript/src/components/Invoices/common/InvoiceForm/Header/index.tsx
Outdated
Show resolved
Hide resolved
apoorv1316
reviewed
Mar 13, 2024
app/javascript/src/components/Invoices/popups/StripeDisabledInvoice.tsx
Outdated
Show resolved
Hide resolved
apoorv1316
approved these changes
Mar 13, 2024
prasanthchaduvula
approved these changes
Mar 13, 2024
nisusam
changed the title
Disable Stripe for specific Invoice
Disable Stripe for specific Invoice for desktop
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stripe_enabled
boolean flag associated with each invoicestripe
settings while generating an invoiceStripeDisabled
modal and use the same while generating an invoiceEdit Invoice
workflowStripeDisabled
modalstripe_enabled
in edit formInvoiceSettings
sidebar to a higher level to use it in bothGenerate Invoice
andEdit Invoice
formsstripe_enabled
value in API responseVideo Reference
Screen.Recording.2024-03-12.at.7.26.51.PM.mov