Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Stripe for specific Invoice for desktop #1692

Merged
merged 15 commits into from
Mar 13, 2024

Conversation

nisusam
Copy link
Contributor

@nisusam nisusam commented Mar 7, 2024

  • Fix Disable Stripe for specific Invoice #1664
  • Add stripe_enabled boolean flag associated with each invoice
  • Save stripe settings while generating an invoice
  • Add the StripeDisabled modal and use the same while generating an invoice
  • Update Edit Invoice workflow
  • Fix the condition to show the StripeDisabled modal
  • Send updated value of stripe_enabled in edit form
  • Move the InvoiceSettings sidebar to a higher level to use it in both Generate Invoice and Edit Invoice forms
  • Send stripe_enabled value in API response

Video Reference

Screen.Recording.2024-03-12.at.7.26.51.PM.mov

Nishant Samel and others added 9 commits March 7, 2024 21:28
- Show `settings` gear icon to open `InvoiceSettings` modal
- Fix condition to show `StripeDisabled` modal
- Send updated value of `stripe_enabled` in edit form
- Move `InvoiceSettings` sidebar to higher level to use it in both
  `Generate Invoice` and `Edit Invoice` screens
- Send `stripe_enabled` value in API response
@nisusam nisusam marked this pull request as ready for review March 12, 2024 10:35
Copy link
Contributor

@gowsik-ragunath gowsik-ragunath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@prasanthchaduvula prasanthchaduvula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes

@nisusam nisusam changed the title Disable Stripe for specific Invoice Disable Stripe for specific Invoice for desktop Mar 13, 2024
@nisusam nisusam merged commit 00719de into develop Mar 13, 2024
1 check passed
@nisusam nisusam deleted the stripe_settings_for_invoices branch March 13, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Stripe for specific Invoice
4 participants