Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logo bugs #1742

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Logo bugs #1742

merged 3 commits into from
Mar 21, 2024

Conversation

Shruti-Apte
Copy link
Contributor

@Shruti-Apte Shruti-Apte commented Mar 21, 2024 •
edited

Closes bug 1 from issue #1716
Closes issue #1731

What

  • Added missing headers for form data while sending a request
  • clientLogo attribute was missing in the reports API, so fetching the client logo from the reports array.

Note

  • Bug 2 from issue 1716 needs backend changes.

Preview

Screen.Recording.2024-03-21.at.11.04.39.AM.mov

@Shruti-Apte Shruti-Apte merged commit 8ac6bf5 into develop Mar 21, 2024
1 check passed
@Shruti-Apte Shruti-Apte deleted the logo_bugs branch March 21, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nisusam nisusam nisusam approved these changes

@apoorv1316 apoorv1316 apoorv1316 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Shruti-Apte @nisusam @apoorv1316