Export options for revenue & invoice reports #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisusam
requested changes
May 24, 2024
app/javascript/src/components/Reports/RevenueByClientReport/index.tsx
Outdated
Show resolved
Hide resolved
| <% report_data[:clients].each do |client| %> | ||
| <tr> | ||
| <td><%= client[:name] %></td> | ||
| <td><%= FormatAmountService.new(report_data[:base_currency],client[:overdue_amount]).process %></td> |
There was a problem hiding this comment.
Use variable for report_data[:base_currency]
nisusam
requested changes
May 29, 2024
| @@ -26,6 +26,7 @@ | |||
| </thead> | |||
| <tbody> | |||
| <% report_data[:clients].each do |client| %> | |||
| <% base_currency = report_data[:base_currency] %> | |||
There was a problem hiding this comment.
Move it before the loop & reuse the same everywhere
| <tbody> | ||
| <% if report_data[:clients].present? %> | ||
| <% report_data[:clients].each do |client| %> | ||
| <% base_currency = report_data[:base_currency] %> |
apoorv1316
force-pushed
the
export-options-for-remaining-reports
branch
from
131c82a
to
838314a
Compare
nisusam
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.