Update time entry status to billed once the invoice is sent to the client #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murtaza-bagwala
requested review from
shivamsinghchahar,
rohitjoshixyz and
akhilgkrishnan
murtaza-bagwala
changed the title
Current Code Coverage Percent of this PR:98.17 %Files having coverage below 100%
|
murtaza-bagwala
changed the title
|
I will review it tomorrow. |
shivamsinghchahar
suggested changes
Apr 19, 2022
There was a problem hiding this comment.
@murtaza-bagwala Suggested some changes. We will also need to add unit test for update_timesheet_entry_status!
| @@ -47,7 +47,7 @@ def send_invoice | |||
| authorize invoice | |||
|
|
|||
| invoice.send_to_email(subject: invoice_email_params[:subject], recipients: invoice_email_params[:recipients]) | |||
|
|
|||
| invoice.update_timesheet_entry_status | |||
There was a problem hiding this comment.
Suggested change
| invoice.update_timesheet_entry_status | |
| invoice.update_timesheet_entry_status! |
app/models/invoice.rb
Outdated
| @@ -62,4 +62,9 @@ class Invoice < ApplicationRecord | |||
| def sub_total | |||
| @_sub_total ||= invoice_line_items.sum { |line_item| line_item[:rate] * line_item[:quantity] } | |||
| end | |||
|
|
|||
| def update_timesheet_entry_status | |||
There was a problem hiding this comment.
Suggested change
| def update_timesheet_entry_status | |
| def update_timesheet_entry_status! |
app/models/invoice.rb
Outdated
| @@ -62,4 +62,9 @@ class Invoice < ApplicationRecord | |||
| def sub_total | |||
| @_sub_total ||= invoice_line_items.sum { |line_item| line_item[:rate] * line_item[:quantity] } | |||
| end | |||
|
|
|||
| def update_timesheet_entry_status | |||
| timesheet_entry_ids = invoice_line_items.map { |line_item| line_item.timesheet_entry_id } | |||
There was a problem hiding this comment.
Suggested change
| timesheet_entry_ids = invoice_line_items.map { |line_item| line_item.timesheet_entry_id } | |
| timesheet_entry_ids = invoice_line_items.pluck(:timesheet_entry_id) |
app/models/invoice.rb
Outdated
|
|
||
| def update_timesheet_entry_status | ||
| timesheet_entry_ids = invoice_line_items.map { |line_item| line_item.timesheet_entry_id } | ||
| TimesheetEntry.where(id: timesheet_entry_ids).update(bill_status: :billed) |
There was a problem hiding this comment.
Suggested change
| TimesheetEntry.where(id: timesheet_entry_ids).update(bill_status: :billed) | |
| TimesheetEntry.where(id: timesheet_entry_ids).each(&:billed!) |
rohitjoshixyz
approved these changes
Apr 20, 2022
shivamsinghchahar
approved these changes
Apr 20, 2022
shivamsinghchahar
deleted the
update-time-entry-status-once-the-invoice-is-sent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion card
Summary
https://www.notion.so/saeloun/6afc9500b2cc42af86be55f37894fb09?v=b4528f26f4424af7beaf036262796cb3&p=430921c655ed4421a3187268d6707283
Preview
NA
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist:
closes #257