Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect Safe contract addresses using configured RPC #200

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Feb 24, 2023

  • When using the safe_creator use L2 Safe version always unless the network is mainnet
  • Allow L2 Safes updating (previously only not L2 Safes were supported)

- When using the safe_creator use `L2 Safe` version always unless the network is `mainnet`
- Allow L2 Safes updating (previously only not L2 Safes were supported)
@coveralls
Copy link

coveralls commented Feb 24, 2023

Pull Request Test Coverage Report for Build 4263007063

  • 15 of 37 (40.54%) changed or added relevant lines in 3 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.3%) to 52.349%

Changes Missing Coverage Covered Lines Changed/Added Lines %
safe_cli/safe_creator.py 0 4 0.0%
safe_cli/operators/safe_operator.py 6 14 42.86%
safe_cli/safe_addresses.py 9 19 47.37%
Files with Coverage Reduction New Missed Lines %
safe_cli/operators/safe_operator.py 2 72.73%
safe_cli/safe_creator.py 2 0%
Totals Coverage Status
Change from base Build 4253101849: -0.3%
Covered Lines: 713
Relevant Lines: 1362

💛 - Coveralls

@Uxio0 Uxio0 merged commit 09e192a into master Mar 14, 2023
@Uxio0 Uxio0 deleted the detect-addresses-network branch March 14, 2023 09:45
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants