Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support v1.4.1 contracts #266

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Support v1.4.1 contracts #266

merged 5 commits into from
Oct 13, 2023

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Sep 25, 2023 •
edited

@coveralls
Copy link

coveralls commented Sep 27, 2023 •
edited

Pull Request Test Coverage Report for Build 6350878518

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.269%
Totals Coverage Status
Change from base Build 6338720757: 0.0%
Covered Lines: 916
Relevant Lines: 1087
💛 - Coveralls

@Uxio0 Uxio0 marked this pull request as ready for review September 28, 2023 12:15
@Uxio0 Uxio0 mentioned this pull request Oct 11, 2023
Merged
moisses89
moisses89 requested changes Oct 13, 2023
View reviewed changes
safe_cli/safe_addresses.py Outdated
"0x29fcB43b46531BcA003ddC8FCB67FFE91900C762", # v1.4.1
"0x3E5c63644E683549055b9Be8653de26E0B4CD36E", # v1.3.0
"0xfb1bffC9d739B8D520DaF37dF666da4C687191EA", # v1.3.0
"0xfb1bffC9d739B8D520DaF37dF666da4C687191EA", # v1.3.0 zkSync
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess zksync contract address is different to 1.3.0.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, this was a typo. I've just fixed and added missing zksync addresses

safe_cli/safe_addresses.py Show resolved Hide resolved
safe_cli/safe_addresses.py Show resolved Hide resolved
@Uxio0 Uxio0 merged commit 688bc16 into master Oct 13, 2023
9 of 13 checks passed
@Uxio0 Uxio0 deleted the support-141 branch October 13, 2023 11:49
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Safe contracts v1.4.1
3 participants
@Uxio0 @coveralls @moisses89