Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase coverage #279

Merged
merged 14 commits into from
Oct 20, 2023
Merged

Increase coverage #279

merged 14 commits into from
Oct 20, 2023

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Oct 11, 2023 •
edited

Technical steps performed

  • Use TransactionServiceApi from safe-eth-py
  • Add tests for entrypoint
  • Add test for SafeLexer
  • Add tests for safe completer and utils
  • Add test for safe_creator
  • Remove pyfiglet (replace by art, due to Python 3.8 not supported anymore)
  • Check safe-cli package is valid before release
  • Add tx service operator delegate tests
  • Add test for submit_signatures
  • Split argparse validators into file
  • Add mock files for tx service
  • Test some missing functions for tx service operator
  • Remove old gnosis tx service test
  • Add missing docs
  • Remove redundant information

@Uxio0 Uxio0 changed the title increase coverage Increase coverage Oct 11, 2023
@coveralls
Copy link

coveralls commented Oct 13, 2023 •
edited

Coverage Status

coverage: 91.927% (+8.1%) from 83.849% when pulling 36de0b5 on increase-coverage into 2fadb42 on master.

Uxio0 and others added 11 commits October 17, 2023 16:50
moisses89
moisses89 approved these changes Oct 18, 2023
View reviewed changes
safe_cli/argparse_validators.py
Ethereum private key validator for ArgParse

:param private_key: Ethereum Private key
:return: Ethereum Private key
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the return comment on the other argparse functions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

safe_cli/main.py Outdated
def __init__(self, safe_address: ChecksumAddress, node_url: str, history: bool):
"""
:param safe_address: Safe address
:param node_url: Ethereum RPC url for the Safe address chain
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Ethereum RPC is enough for the Safe address chain is confusing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, removed

@Uxio0 Uxio0 merged commit 09e8507 into master Oct 20, 2023
13 checks passed
@Uxio0 Uxio0 deleted the increase-coverage branch October 20, 2023 14:16
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@moisses89 moisses89 moisses89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase coverage to at least 80%
3 participants
@Uxio0 @coveralls @moisses89