Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support m derivation path #301

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Support m derivation path #301

merged 3 commits into from
Nov 8, 2023

Conversation

moisses89
Copy link
Member

Closes #299

@moisses89 moisses89 requested a review from Uxio0 as a code owner November 7, 2023 17:47
@moisses89
Copy link
Member Author

@Uxio0 Tests are expected to fail due the next issue #302.

@coveralls
Copy link

coveralls commented Nov 8, 2023 •
edited

Coverage Status

coverage: 93.027% (+0.007%) from 93.02%
when pulling b7ca9db on support_m_derivation_path
into e79d1d4 on master.

@moisses89
Copy link
Member Author

@Uxio0 Tests are expected to fail due the next issue #302.

Removing the failing test because is not related with the goal of this issue, the failing test should be added in the PR that closes #302

Uxio0
Uxio0 approved these changes Nov 8, 2023
View reviewed changes
tests/test_ledger_manager.py Outdated Show resolved Hide resolved
@moisses89 @Uxio0
Update tests/test_ledger_manager.py
b7ca9db 
Co-authored-by: Uxío <Uxio0@users.noreply.github.com>
@moisses89 moisses89 merged commit d99afd2 into master Nov 8, 2023
13 checks passed
@moisses89 moisses89 deleted the support_m_derivation_path branch November 8, 2023 12:33
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Uxio0 Uxio0 Uxio0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ledger derivation path not accepting initial m/ as valid
3 participants
@moisses89 @coveralls @Uxio0