Add Trezor support #318
Merged
Add Trezor support #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moisses89
force-pushed
the
add_trezor_support
branch
from
c11e6b8
to
a8bc569
Compare
moisses89
force-pushed
the
add_trezor_support
branch
2 times, most recently
from
5aee1b2
to
1b33231
Compare
Uxio0
requested changes
Dec 1, 2023
safe_cli/operators/safe_operator.py
Outdated
| @@ -183,7 +171,7 @@ def __init__(self, address: ChecksumAddress, node_url: str): | |||
| self.require_all_signatures = ( | |||
| True # Require all signatures to be present to send a tx | |||
| ) | |||
| self.ledger_manager = load_ledger_manager() | |||
| self.hw_account_manager = HwAccountManager() | |||
There was a problem hiding this comment.
Nice, I like the refactor on the operator!
moisses89
force-pushed
the
add_trezor_support
branch
from
7e3c966
to
66e4fdc
Compare
moisses89
force-pushed
the
add_trezor_support
branch
from
66e4fdc
to
63c3481
Compare
Uxio0
requested changes
Dec 12, 2023
Uxio0
approved these changes
Dec 12, 2023
moisses89
force-pushed
the
add_trezor_support
branch
from
019feca
to
f094ab5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Support Trezor for signing #270