Support execute transaction from Trezor #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uxio0
reviewed
Jan 15, 2024
| ] | ||
| ).hex() | ||
|
|
||
| return HexStr(encoded_transaction) |
There was a problem hiding this comment.
Shouldn't we return bytes or HexBytes here? That's what we do everywhere we are returning raw transactions or data, also it's more friendly memory wise
There was a problem hiding this comment.
Make sense, I was returning HexStr to be consistent with ledger response, but I think that is better to be consistent with our code as we are using bytes normally to represent raw_transactions.
moisses89
force-pushed
the
support_execute_transactions_from_trezor
branch
from
3f1215c
to
25676bd
Compare
Uxio0
approved these changes
Jan 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #326