Add support to remove not executed transactions #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are expected to fail because new version of |
moisses89
force-pushed
the
add_delete_transaction
branch
from
6315aa1
to
8b52d49
Compare
moisses89
commented
Feb 1, 2024
| ) | ||
| message_hash = eip712_encode_hash(eip712_message) | ||
| try: | ||
| safe_tx, _ = self.safe_tx_service.get_safe_transaction(safe_tx_hash) |
There was a problem hiding this comment.
Add a warning and ask for confirmation if the transaction have all the required signatures and it is ready to execute.
There was a problem hiding this comment.
Maybe you can add this explanation as a comment
There was a problem hiding this comment.
@Uxio0 I'm thinking to add a yes or no question is this case to ensure that the user reads the message and he is aware that burn the nonce is the best option after this.
Uxio0
requested changes
Feb 2, 2024
| ) | ||
| message_hash = eip712_encode_hash(eip712_message) | ||
| try: | ||
| safe_tx, _ = self.safe_tx_service.get_safe_transaction(safe_tx_hash) |
There was a problem hiding this comment.
Maybe you can add this explanation as a comment
Uxio0
approved these changes
Feb 15, 2024
Co-authored-by: Uxío <Uxio0@users.noreply.github.com>
Add check for keccak hash
Co-authored-by: Uxío <Uxio0@users.noreply.github.com>
moisses89
force-pushed
the
add_delete_transaction
branch
from
4757448
to
eaa6fae
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #306