Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unloaded proposer removing transaction #359

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Fix unloaded proposer removing transaction #359

merged 1 commit into from
Feb 19, 2024

Conversation

moisses89
Copy link
Member

@moisses89 moisses89 commented Feb 19, 2024 •
edited

Fix missing return when proposer was not loaded between signers.
Close #360

@coveralls
Copy link

coveralls commented Feb 19, 2024 •
edited

Coverage Status

coverage: 95.146% (+0.009%) from 95.137%
when pulling 1f1b0eb on fix_unloaded_proposer
into 0560d9d on master.

@moisses89 moisses89 marked this pull request as draft February 19, 2024 09:33
@moisses89 moisses89 marked this pull request as ready for review February 19, 2024 09:46
@moisses89 moisses89 merged commit 8a39352 into master Feb 19, 2024
13 checks passed
@moisses89 moisses89 deleted the fix_unloaded_proposer branch February 19, 2024 09:55
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Uxio0 Uxio0 Uxio0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI crashing when executing remove_proposed_transaction command with an owner that did not propose that tx
3 participants
@moisses89 @coveralls @Uxio0