Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set invalidation time of keys deleted via pattern #1076

Closed
wants to merge 1 commit into from
Closed

Set invalidation time of keys deleted via pattern #1076

wants to merge 1 commit into from

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Jan 29, 2024 •
edited

This adjusts RedisCacheService['deleteByKeyPattern'] to set the invalidationTimeMs:* of each key deleted as they were not being set:

Changes

  • New setInvalidationTime method extracted from and called in deleteByKey.
  • Said method called in deleteByKeyPattern with non-prefixed keys (from new _removePrefixFromKey method).

Test coverage has been added for the above in the same manner as that testing the invalidation times set in deleteByKey.

@iamacook iamacook self-assigned this Jan 29, 2024
@iamacook iamacook requested a review from a team as a code owner January 29, 2024 13:01
@iamacook
Copy link
Member Author

Closing in favour of removing deleteByKeyPattern as it is no longer used.

@iamacook iamacook closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@iamacook iamacook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@iamacook