Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add owners/:ownerAddress/safes endpoint for all Safes on all chains #1097

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Feb 1, 2024

This adds a new GET owners/:ownerAddress/safes endpoint for retrieving all Safes on all chains for a specified ownerAddress, returning { [chainId: string]: Array<string> } of addresses.

@iamacook iamacook self-assigned this Feb 1, 2024
@iamacook iamacook requested a review from a team as a code owner February 1, 2024 14:47
@hectorgomezv hectorgomezv added the in review Someone is reviewing this Pull Request label Feb 2, 2024
@hectorgomezv hectorgomezv removed the in review Someone is reviewing this Pull Request label Feb 2, 2024
Copy link
Member

@hectorgomezv hectorgomezv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a small nitpick comment, but apart from that LGTM! 👏🏻

@iamacook iamacook merged commit 4194bde into main Feb 2, 2024
16 checks passed
@iamacook iamacook deleted the all-safes branch February 2, 2024 12:46
hectorgomezv pushed a commit that referenced this pull request Feb 2, 2024
…#1097)

This adds a new `GET` `owners/:ownerAddress/safes` endpoint for retrieving all Safes on all chains.

---

* Add `owners/:ownerAddress/safes` endpoint for all Safes on all chains

* Add second mock chain to test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants