Move AccountDoesNotExistError to domain #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While `AccountDoesNotExistError` is an error that originates from the DataSource, these errors can and should also be used in the Domain layer. Since the Domain layer is the one specifying the interface for the DataSource to implement, then specifying that the error can also be thrown by implementations of the interface, hints that it is a domain-specific error.
iamacook
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While
AccountDoesNotExistErroris an error that originates from the DataSource, these errors can and should also be used in the Domain layer.Since the Domain layer is the one specifying the interface for the DataSource to implement, then specifying that the error can also be thrown by implementations of the interface, hints that it is a domain-specific error.