-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GET
/v1/safes
overview endpoint
#1129
Conversation
Pull Request Test Coverage Report for Build 8389550937Details
💛 - Coveralls |
e26974d
to
3e48238
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the incompatibilities with newer code changes in safes.controller.overview.spec.ts
, it looks good to me!
@@ -10,6 +10,7 @@ export interface IBalancesRepository { | |||
getBalances(args: { | |||
chainId: string; | |||
safeAddress: string; | |||
fiatCode: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This adds a new
GET
/v1/safes
endpoint for "overviews" of specified Safes, returning the following:It requires the following search parameters:
currency
andsafes
. It also acceptswallet_address
,exclude_spam
andtrusted
search parameters:currency
The desired fiat to return the balance of the Safe in, e.g.
USD
safes
A CAIP-10 comma separated list of Safe addresses, without the EIP155 namespace, e.g.
1:0x123...,1:0x456...,137:0x789
.MAX_SAFE_OVERVIEWS
env. var.walletAddress
The owner which is checked for awaiting confirmations as a "standard" address, e.g.
0x123...
trusted
(default:false
)Whether to return "trusted" transactions or not.
exclude_spam
(default:true
)Whether to exclude "spam" tokens or not.