Add support for Database certificate pinning #1235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds support for pinning a CA certificate. - If SSL is enabled: * `POSTGRES_SSL_REQUEST_CERT` can be used to make Postgres request a certificate from the clients. (default `true`) * `POSTGRES_SSL_CA_PATH` can be used to specify the absolute path to the certificate file (no default). * More details can be found in https://nodejs.org/api/tls.html#tlscreateserveroptions-secureconnectionlistener - The self-signed certificated is a X509 certificate with validity of 365 days. The Common Name (CN) is `localhost`. - The local development instance `db`, does not have SSL configured (i.e.: no changes). - The local test instance `db-test`, has SSL configured and will use the self-signed certificate available under `<projectRoot>/db_config/test`. * With the described setup, we are testing if the connection options are valid.
Pull Request Test Coverage Report for Build 8157440422Details
💛 - Coveralls |
hectorgomezv
requested changes
Mar 4, 2024
hectorgomezv
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POSTGRES_SSL_REQUEST_CERTcan be used to make Postgres request a certificate from the clients. (defaulttrue)POSTGRES_SSL_CA_PATHcan be used to specify the absolute path to the certificate file (no default).localhost.Docker
db, does not have SSL configured (i.e.: no changes).db-test, has SSL configured and will use the self-signed certificate available under<projectRoot>/db_config/test.