Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify readonly class variables name convention #1238

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Unify readonly class variables name convention #1238

merged 1 commit into from
Mar 5, 2024

Conversation

hectorgomezv
Copy link
Member

Changes

  • Changes several variable naming conventions at CoingeckoApi to meet the screaming snake case format

@hectorgomezv hectorgomezv self-assigned this Mar 4, 2024
@hectorgomezv hectorgomezv requested a review from a team as a code owner March 4, 2024 15:39
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8142912951

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 93.244%
Files with Coverage Reduction New Missed Lines %
src/routes/transactions/entities/tests/human-description.builder.ts 2 80.0%
Totals Coverage Status
Change from base Build 8141876613: -0.06%
Covered Lines: 6382
Relevant Lines: 6602
💛 - Coveralls

@hectorgomezv hectorgomezv merged commit 96d51d3 into main Mar 5, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the unify-class-variables-format branch March 5, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamacook iamacook iamacook approved these changes

Assignees

@hectorgomezv hectorgomezv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hectorgomezv @coveralls @iamacook