Pass Tenderly headers correctly #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8157719394Details
💛 - Coveralls |
hectorgomezv
requested changes
Mar 4, 2024
| } catch (error) { | ||
| console.log(error); |
| @@ -70,7 +74,7 @@ export class TenderlyApi implements IAlertsApi { | |||
| async deleteContract(contract: AlertsDeletion): Promise<void> { | |||
| try { | |||
| const url = `${this.baseUrl}/api/v1/account/${this.account}/project/${this.project}/contract/${contract.chainId}/${contract.address}`; | |||
| await this.networkService.delete(url, { | |||
| await this.networkService.delete(url, undefined, { | |||
There was a problem hiding this comment.
This is out of the scope of this PR, but I'm considering it would be beneficial to accept arguments via an interface in this class functions (args: {...}) as we do in other places, to avoid hardcoding undefined which could be a bit error-prone.
There was a problem hiding this comment.
I agree that it's a good addition. I will keep in mind for a follow up!
iamacook
force-pushed
the
tenderly-headers
branch
from
d20dbd2
to
ce88e34
Compare
hectorgomezv
previously approved these changes
Mar 4, 2024
fmrsabino
reviewed
Mar 5, 2024
Comment on lines
60
to
64
| async delete<T>( | ||
| baseUrl: string, | ||
| data?: object, | ||
| { params, headers }: NetworkRequest = {}, | ||
| ): Promise<NetworkResponse<T>> { |
There was a problem hiding this comment.
Is this part of this PR 🤔 I would scope it only with the Tenderly changes.
There was a problem hiding this comment.
This was a rebase issue. It should now be resolved.
hectorgomezv
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the Tenderly requests to pass the
bodyandheaderscorrectly.Changes
addContract/deleteContractnetwork request payloads