Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Zerion balances icons nullable #1249

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Make Zerion balances icons nullable #1249

merged 2 commits into from
Mar 5, 2024

Conversation

hectorgomezv
Copy link
Member

@hectorgomezv hectorgomezv commented Mar 5, 2024 •
edited

Summary

This PR fixes a bug in the ZerionFungibleInfo definition, as the icon was marked as required by mistake.
Docs: https://developers.zerion.io/reference/listwalletpositions

Changes

  • Makes ZerionFungibleInfo.icon nullable.

@hectorgomezv hectorgomezv self-assigned this Mar 5, 2024
@hectorgomezv hectorgomezv requested a review from a team as a code owner March 5, 2024 13:57
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8157429987

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 93.28%
Files with Coverage Reduction New Missed Lines %
src/routes/transactions/entities/tests/human-description.builder.ts 3 60.0%
Totals Coverage Status
Change from base Build 8157075120: 0.01%
Covered Lines: 6384
Relevant Lines: 6606
💛 - Coveralls

@hectorgomezv hectorgomezv changed the title Makes Zerion balances icons nullable Make Zerion balances icons nullable Mar 5, 2024
@hectorgomezv hectorgomezv merged commit 5673a20 into main Mar 5, 2024
16 checks passed
@hectorgomezv hectorgomezv deleted the fix-zerion-icon-urls-default branch March 5, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamacook iamacook iamacook approved these changes

Assignees

@hectorgomezv hectorgomezv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hectorgomezv @coveralls @iamacook